midipix / build / midipix_build

Forked from build/midipix_build 4 years ago
Clone
Blob Blame History Raw
From 2fab90a71acd3698954c08b9062db67188443dd7 Mon Sep 17 00:00:00 2001
From: midipix <writeonce@midipix.org>
Date: Sat, 14 Jul 2018 22:49:06 -0400
Subject: [PATCH 1/2] remove inclusion guard hacks for sys/kd.h
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

maintainer's note: at some point, probably long before linux separated
the uapi headers, it was the case, or at least I believed it was the
case, that linux/types.h was unsafe to include from userspace. thus,
the inclusion guard macro _LINUX_TYPES_H was defined in sys/kd.h to
prevent linux/kd.h from including linux/types.h (which it spuriously
includes but does not use). as far as I can tell, whatever problem
this was meant to solve does not seem to have been present for a long
time, and the hack was not done correctly anyway, so removing it is
the right thing to do.

Signed-off-by: Lucio Andrés Illanes Albornoz <lucio@lucioillanes.de>
---
 include/sys/kd.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/include/sys/kd.h b/include/sys/kd.h
index 793fd59f..33b873f4 100644
--- a/include/sys/kd.h
+++ b/include/sys/kd.h
@@ -1,8 +1 @@
-#ifndef _SYS_KD_H
-#define _SYS_KD_H
-
-#define _LINUX_TYPES_H
 #include <linux/kd.h>
-#undef _LINUX_TYPES_H
-
-#endif
-- 
2.17.0