supporting -Wl,-undefined -Wl,dynamic_lookup when targeting Mach-O

orbea commented

2020-09-12 23:42:36 +00:00

Original issue: https://github.com/midipix-project/slibtool/issues/15
Opened by: @midipix

midipix commented on Feb 16, 2019:

Another thing to consider: the -undefined linker flag which instructs what to do when a shared library refers to symbols not resolved at link time. Example (here using GNU ar from MacPorts port:binutils as a temporary solution):

> CD zfs-git/lib/libuutil/ rlibtool --verbose --ar=/opt/local/bin/gar --tag=CC --silent --mode=link ccache /opt/local/bin/clang-mp-5.0 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wno-tautological-constant-out-of-range-compare -D_GNU_SOURCE -D__EXTENSIONS__ -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DTEXT_DOMAIN=\"zfs-osx-user\" -O3 -march=native -g -mmacosx-version-min=10.9 -isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -arch x86_64 -g -version-info 1:1:0 -L/opt/local/lib -Wl,-headerpad_max_install_names -O3 -march=native -g -mmacosx-version-min=10.9 -Wl,-syslibroot,/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -arch x86_64 -o libuutil.la -rpath /opt/local/lib uu_alloc.lo uu_avl.lo uu_dprintf.lo uu_ident.lo uu_list.lo uu_misc.lo uu_open.lo uu_pname.lo uu_string.lo uu_strtoint.lo ../../lib/libavl/libavl.la ../../lib/libspl/libspl.la ../../lib/libefi/libefi.la       /Volumes/Debian/Users/bertin/work/src/MacOSX/osxzfs/zfs-git/lib/libuutil
/opt/local/bin/gar: BFD (GNU Binutils) 2.30 assertion fail archive.c:1859
<SNIP>
ld: warning: option -noall_load is obsolete and being ignored
ld: warning: option -noall_load is obsolete and being ignored
ld: warning: option -noall_load is obsolete and being ignored
Undefined symbols for architecture x86_64:
  "_CFDictionaryGetValueIfPresent", referenced from:
      _CFDictionaryValueIfPresentMatchesSubstring in libefi.a(rdwr_efi.o)
      _isDeviceMatchForKeyAndSubstr in libefi.a(rdwr_efi.o)

Adding -Wl,-undefined -Wl,dynamic_lookup (just after -Wall) fixes the issue. I'm attaching the libtool script for this project.
libtool.txt

Originally posted by @RJVB in #13 (comment)

midipix commented on Feb 16, 2019:

Looking at the attached libtool.txt, it appears to me that rlibtool could detect which flags to use based on the scripts recorded allow_undefined_flag=...

In pure (slibtool) mode, some other mechanism will have to be used, but that is probably a lower priority for now, and would also depend on whether modern tools targeting Mach-O (and most importantly clang's lld) behave in a backward-compatible way.

RJVB commented on Feb 17, 2019:

In pure (slibtool) mode, some other mechanism will have to be used, but that is probably a lower priority for now, and would also depend on whether modern tools targeting Mach-O (and most importantly clang's lld) behave in a backward-compatible way.
Let me just repeat that I do use modern toolchains, including the compiler, linker and everything from what Apple call the cctools package.

Original issue: https://github.com/midipix-project/slibtool/issues/15 Opened by: @midipix __midipix commented on Feb 16, 2019:__ > Another thing to consider: the -undefined linker flag which instructs what to do when a shared library refers to symbols not resolved at link time. Example (here using GNU ar from MacPorts port:binutils as a temporary solution): > > ``` > > CD zfs-git/lib/libuutil/ rlibtool --verbose --ar=/opt/local/bin/gar --tag=CC --silent --mode=link ccache /opt/local/bin/clang-mp-5.0 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wno-tautological-constant-out-of-range-compare -D_GNU_SOURCE -D__EXTENSIONS__ -D_REENTRANT -D_POSIX_PTHREAD_SEMANTICS -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -DTEXT_DOMAIN=\"zfs-osx-user\" -O3 -march=native -g -mmacosx-version-min=10.9 -isysroot/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -arch x86_64 -g -version-info 1:1:0 -L/opt/local/lib -Wl,-headerpad_max_install_names -O3 -march=native -g -mmacosx-version-min=10.9 -Wl,-syslibroot,/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk -arch x86_64 -o libuutil.la -rpath /opt/local/lib uu_alloc.lo uu_avl.lo uu_dprintf.lo uu_ident.lo uu_list.lo uu_misc.lo uu_open.lo uu_pname.lo uu_string.lo uu_strtoint.lo ../../lib/libavl/libavl.la ../../lib/libspl/libspl.la ../../lib/libefi/libefi.la /Volumes/Debian/Users/bertin/work/src/MacOSX/osxzfs/zfs-git/lib/libuutil > /opt/local/bin/gar: BFD (GNU Binutils) 2.30 assertion fail archive.c:1859 > <SNIP> > ld: warning: option -noall_load is obsolete and being ignored > ld: warning: option -noall_load is obsolete and being ignored > ld: warning: option -noall_load is obsolete and being ignored > Undefined symbols for architecture x86_64: > "_CFDictionaryGetValueIfPresent", referenced from: > _CFDictionaryValueIfPresentMatchesSubstring in libefi.a(rdwr_efi.o) > _isDeviceMatchForKeyAndSubstr in libefi.a(rdwr_efi.o) > ``` > > Adding `-Wl,-undefined -Wl,dynamic_lookup` (just after -Wall) fixes the issue. I'm attaching the libtool script for this project. > [libtool.txt](https://github.com/midipix-project/slibtool/files/2871987/libtool.txt) > > _Originally posted by @RJVB in [#13 (comment)](https://github.com/midipix-project/slibtool/issues/13#issuecomment-464348590)_ __midipix commented on Feb 16, 2019:__ > Looking at the attached libtool.txt, it appears to me that rlibtool could detect which flags to use based on the scripts recorded `allow_undefined_flag=...` > > In _pure_ (slibtool) mode, some other mechanism will have to be used, but that is probably a lower priority for now, and would also depend on whether modern tools targeting Mach-O (and most importantly clang's lld) behave in a backward-compatible way. __RJVB commented on Feb 17, 2019:__ > In _pure_ (slibtool) mode, some other mechanism will have to be used, but that is probably a lower priority for now, and would also depend on whether modern tools targeting Mach-O (and most importantly clang's lld) behave in a backward-compatible way. > Let me just repeat that I do use modern toolchains, including the compiler, linker and everything from what Apple call the cctools package.

orbea commented

2024-02-17 21:00:05 +00:00

Author

@RJVB Is there something left to fix here or should this issue be closed?

midipix commented

2024-02-23 07:34:32 +00:00

Owner

In theory, one could argue that when targeting Darwin, and unless -no-undefined has been specified, -Wl,-undefined -Wl,dynamic_lookup should be automatically added. @RJVB, is that correct?

In theory, one could argue that when targeting Darwin, and unless `-no-undefined` has been specified, `-Wl,-undefined -Wl,dynamic_lookup` should be automatically added. @RJVB, is that correct?

midipix commented

2025-05-19 13:55:34 +00:00

Owner

@RJVB still waiting for your input and testing here and on #59, thanks!

Rows
Columns

supporting -Wl,-undefined -Wl,dynamic_lookup when targeting Mach-O #6