Issue #3: Infinite loop if 'libtool' heuristics file isn't found - slibtool

cross / slibtool

#3 Infinite loop if 'libtool' heuristics file isn't found

Closed 4 years ago by midipix. Opened 4 years ago by rossburton.

I thought I'd experiment with slibtool so built it and passed LIBTOOL=rlibtool to libx11's make command.

I now have 20 slibtool processes all infinite-looping:

fstat(4, {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
openat(4, "libtool", O_RDONLY)          = -1 ENOENT (No such file or directory)
openat(4, "../", O_RDONLY|O_DIRECTORY)  = 3
close(4)

This is a cross-compiled Yocto environment with our own "fun" libtool patches, so the generated libtool script in the build directory is called aarch64-poky-linux-libtool. slibtool isn't handling the heuristics file being not found.

midipix commented 4 years ago

Confirmed, thanks for the catch While slbt_lconf_conf() already guards against moving up the directory tree to a different device, it did not guard against an infinite loop as a result of reaching the top-level root directory.

midipix commented 4 years ago

Fixed in commit 0b404d0, awaiting verification.

orbea commented 4 years ago

@rossburton Can you confirm is this is fixed or not? :)

midipix commented 4 years ago

Good news: 2c4e5f9 fixes the libxml2 build.

I'll take the above update by @rossburton from issue #15 as that confirmation:=)

Metadata Update from @midipix:
- Issue status updated to: Closed (was: Open)

4 years ago

Metadata

Assignee

None

Tags

None

Blocking

None

Depending on

None

cross / slibtool

Source Code

#3 Infinite loop if 'libtool' heuristics file isn't found Closed 4 years ago by midipix. Opened 4 years ago by rossburton.

Metadata

#3 Infinite loop if 'libtool' heuristics file isn't found

Closed 4 years ago by midipix. Opened 4 years ago by rossburton.