build.sh fails on Adelie Linux due to missing which(1) + misleads the operator #13

New issue

Open

opened 2024-07-06 11:08:10 +00:00 by sskras · 2 comments

sskras commented

2024-07-06 11:08:10 +00:00

Adelie-BA34AA ~/midipix_build # ./build.sh -a nt64 -b release -D zipdist -P -v
==> 2024/07/06 14:00:09 Error: Error: missing prerequisite package(s): awk bunzip2 bzip2 cat chmod cmake cp date find flock g++ gcc git grep gunzip gzip hostname id install kill ln lzip make mkdir mkfifo mktemp mv paste patch perl pgrep pkill printf readlink rm sed sha256sum sort stat tail tar test touch tr uniq wget xz zip

These seemingly are names of the binaries. I copied all of them and rAn through a shell check to see if any of them is missing. I also added a bogus fake-bin just to be sure my check works:

Adelie-BA34AA ~ # echo; echo 'fake-bin awk bunzip2 bzip2 cat chmod cmake cp date find flock g++ gcc git grep gunzip gzip hostname id install kill ln lzip make mkdir mkfifo mktemp mv paste patch perl pgrep pkill printf readlink rm sed sha256sum sort stat tail tar test touch tr uniq wget xz zip' | fmt -w1 | while read BINARY; do type -p $BINARY >/dev/null || echo Not found: $BINARY; done

Not found: fake-bin

And no, all they seems to be present on disk (except for that bogus name).

``` Adelie-BA34AA ~/midipix_build # ./build.sh -a nt64 -b release -D zipdist -P -v ==> 2024/07/06 14:00:09 Error: Error: missing prerequisite package(s): awk bunzip2 bzip2 cat chmod cmake cp date find flock g++ gcc git grep gunzip gzip hostname id install kill ln lzip make mkdir mkfifo mktemp mv paste patch perl pgrep pkill printf readlink rm sed sha256sum sort stat tail tar test touch tr uniq wget xz zip ``` These seemingly are names of the binaries. I copied all of them and rAn through a shell check to see if any of them is missing. I also added a bogus `fake-bin` just to be sure my check works: ``` Adelie-BA34AA ~ # echo; echo 'fake-bin awk bunzip2 bzip2 cat chmod cmake cp date find flock g++ gcc git grep gunzip gzip hostname id install kill ln lzip make mkdir mkfifo mktemp mv paste patch perl pgrep pkill printf readlink rm sed sha256sum sort stat tail tar test touch tr uniq wget xz zip' | fmt -w1 | while read BINARY; do type -p $BINARY >/dev/null || echo Not found: $BINARY; done Not found: fake-bin ``` And no, all they seems to be present on disk (except for that bogus name).

sskras commented

2024-07-06 11:56:39 +00:00

Author

To test that I ran two things in advance:

# apk update
# apk add build-tools
# apk list binutils bison bzip2 cmake coreutils curl findutils g++ gawk gcc git grep gzip libc-dev linux-headers lzip m4 make musl-dev net-tools patch perl perl-xml-parser procps sed tar util-linux util-linux-dev wget xz zip | awk '!/installed/ {gsub(/[{}]/, "", $3); print $3}' | xargs apk add

The last monstrous shell composite:

gets Alpine package names from README in the stdin
finds which of these names are not installed
passes the resulting names to apk add ...

To test that I ran two things in advance: ``` # apk update # apk add build-tools # apk list binutils bison bzip2 cmake coreutils curl findutils g++ gawk gcc git grep gzip libc-dev linux-headers lzip m4 make musl-dev net-tools patch perl perl-xml-parser procps sed tar util-linux util-linux-dev wget xz zip | awk '!/installed/ {gsub(/[{}]/, "", $3); print $3}' | xargs apk add ``` The last monstrous shell composite: - gets Alpine package names from README in the stdin - finds which of these names are not installed - passes the resulting names to `apk add ...`

sskras commented

2024-07-06 11:59:43 +00:00

Author

Narrowed the scope down to this: https://dev.midipix.org/build/midipix_build/blob/6ecff4/f/subr.rtl/rtl_platform.subr#_18-22

And this is what I found:

Adelie-BA34AA ~/midipix_build # if ! which id ; then echo BAD; else echo OK; fi
-bash: which: command not found
BAD

So the script relies on an optional binary which, which could be easily replaced with POSIX defined shell builtin command -v.

Narrowed the scope down to this: https://dev.midipix.org/build/midipix_build/blob/6ecff4/f/subr.rtl/rtl_platform.subr#_18-22 And this is what I found: ``` Adelie-BA34AA ~/midipix_build # if ! which id ; then echo BAD; else echo OK; fi -bash: which: command not found BAD ``` So the script relies on an optional binary `which`, which could be easily replaced with POSIX defined shell builtin `command -v`.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

build/midipix_build#13

No description provided.

Rows
Columns